Skip to content

Conversation

@otelbot
Copy link
Contributor

@otelbot otelbot bot commented May 9, 2025

Update the OpenTelemetry SDK version to 1.50.0.

@otelbot otelbot bot requested a review from a team as a code owner May 9, 2025 23:48
@github-actions github-actions bot added the test native This label can be applied to PRs to trigger them to run native tests label May 9, 2025
Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @laurit ❤️

.setSeverityText("debug")
.setBody("body")
.setAttribute(AttributeKey.stringKey("key"), "value")
.setAllAttributes(Attributes.builder().put("key", "value").build())
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what do you think about adding extended attributes to the test?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Looks like I forgot to implement bridging for these. Should be fixed now.

import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.Test;

@Disabled // does not work after declarative config changes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this mean declarative config won't work in upcoming agent release?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just wasn't immediately able to figure out how to fix this and wanted to push the rest of the changes out to see whether something else still fails. I'll try to fix it but we may need to ask help from @jack-berg for this.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed the test, idk if I did it correctly. Looking at https://github.com/open-telemetry/opentelemetry-configuration/blob/main/examples/kitchen-sink.yaml it seems that we need to group some of the resource providers. @jack-berg could you review.

@trask trask added this to the v2.16.0 milestone May 15, 2025
@trask trask merged commit a87bb01 into main May 15, 2025
88 checks passed
@trask trask deleted the otelbot/update-opentelemetry-sdk-to-1.50.0 branch May 15, 2025 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test native This label can be applied to PRs to trigger them to run native tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants