-
Notifications
You must be signed in to change notification settings - Fork 1k
Update the OpenTelemetry SDK version to 1.50.0 #13834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @laurit ❤️
| .setSeverityText("debug") | ||
| .setBody("body") | ||
| .setAttribute(AttributeKey.stringKey("key"), "value") | ||
| .setAllAttributes(Attributes.builder().put("key", "value").build()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what do you think about adding extended attributes to the test?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch. Looks like I forgot to implement bridging for these. Should be fixed now.
| import org.junit.jupiter.api.Disabled; | ||
| import org.junit.jupiter.api.Test; | ||
|
|
||
| @Disabled // does not work after declarative config changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this mean declarative config won't work in upcoming agent release?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just wasn't immediately able to figure out how to fix this and wanted to push the rest of the changes out to see whether something else still fails. I'll try to fix it but we may need to ask help from @jack-berg for this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed the test, idk if I did it correctly. Looking at https://github.com/open-telemetry/opentelemetry-configuration/blob/main/examples/kitchen-sink.yaml it seems that we need to group some of the resource providers. @jack-berg could you review.
Update the OpenTelemetry SDK version to
1.50.0.